feat(event-handler): allow for cors=None setting
#421
Merged
+31
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the route level we should allow for cors=None which means that cors are enabled for this route when configured globally
michaelbrewer
changed the title
michaelbrewer
changed the title
cors=None setting
Codecov Report
@@ Coverage Diff @@
## develop #421 +/- ##
========================================
Coverage 99.89% 99.89%
========================================
Files 101 101
Lines 3990 3994 +4
Branches 197 198 +1
========================================
+ Hits 3986 3990 +4
Misses 1 1
Partials 3 3
Continue to review full report at Codecov.
|
heitorlessa
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
At the route level we should allow for
cors=Nonewhich means that cors are enabled for this route when configured globallyapp=ApiGatewayResolver()@app.get("/cors", cors=True)app=ApiGatewayResolver(cors=CORSConfig())@app.get("/cors", cors=True)app=ApiGatewayResolver()@app.get("/no-cors", cors=False)app=ApiGatewayResolver(cors=CORSConfig())@app.get("/no-cors", cors=False)app=ApiGatewayResolver()@app.get("/no-cors")app=ApiGatewayResolver(cors=CORSConfig())@app.get("/cors")Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.